Comments on: Heap Sort in Scala http://ilyasterin.com/blog/2010/01/heap-sort-in-scala.html Against the grain software and startups Thu, 26 Jan 2012 12:50:49 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: Bruno Mendeshttp://ilyasterin.com/blog/2010/01/heap-sort-in-scala.html#comment-119 Bruno Mendes Sat, 14 Aug 2010 17:35:00 +0000 http://ilya.cobrio.com/blog/2010/01/heap-sort-in-scala.html#comment-119 <p>That's just what i was looking for. I´m new to Scala programming and while trying to understand the code i learned some interesting ways to do things, like that (N1 until N2).foreach( param => { code }) it's really useful<br><br>Just one thing, in the end you remove the Best and Worst cases from the bechmarks array, but when you return the average you divide the partial sum by the total length. I think it should be divided by length-2.<br><br>return sum/(sortedBm.length-2)</p><p>Plus, the slice function is returning length-3 items instead of length-2 items, so it should be changed to sortedBm.slice(1,sortedBm.size-1).foreach(sumFunc)</p> That’s just what i was looking for. I´m new to Scala programming and while trying to understand the code i learned some interesting ways to do things, like that (N1 until N2).foreach( param => { code }) it’s really useful

Just one thing, in the end you remove the Best and Worst cases from the bechmarks array, but when you return the average you divide the partial sum by the total length. I think it should be divided by length-2.

return sum/(sortedBm.length-2)

Plus, the slice function is returning length-3 items instead of length-2 items, so it should be changed to sortedBm.slice(1,sortedBm.size-1).foreach(sumFunc)

]]>